Merged
Conversation
|
Size Change: +405 B (+0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
This reverts commit 823a569.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ciampo
reviewed
Sep 25, 2024
Contributor
ciampo
left a comment
There was a problem hiding this comment.
Leaving some code-related comments, as I don't believe that any of these changes should actually cause "runtime" changes
tyxla
reviewed
Sep 25, 2024
ciampo
approved these changes
Sep 25, 2024
packages/base-styles/_mixins.scss
Outdated
Comment on lines
+8
to
+16
| @mixin text-heading() { | ||
| font-family: $font-family-headings; | ||
| font-weight: $font-weight-medium; | ||
| } | ||
|
|
||
| @mixin text-body() { | ||
| font-family: $font-family-body; | ||
| font-weight: $font-weight-regular; | ||
| } |
Contributor
There was a problem hiding this comment.
Since these mixins are (I believe) meant to be only used in this file (at least for now), we could prefix their name with a _ to better indicate their "private" nature — ie. _text-heading and _text-body
ajlende
added a commit
that referenced
this pull request
Oct 16, 2024
jeryj
pushed a commit
that referenced
this pull request
Oct 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
_variables.scssa bit, accounting for the new tokens.$default-fontand$default-line-heightin favor of the new tokens.This PR intentionally does not touch the variables in config-values.js. You can read about why in #64340 (comment).
Why
See #64340.