Writing flow: fix triple click inside text blocks#64928
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +73 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
bph
pushed a commit
to bph/gutenberg
that referenced
this pull request
Aug 31, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: annezazu <annezazu@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: eidolonnight <eidolonnight@git.wordpress.org>
This was referenced Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #64451.
Triple click in a paragraph currently selects the next block also. This is a small regression after #63671.
Also fixes #53128, which was a bug that existed long before #63671!
Why?
Triple should be contained in the block.
How?
The problem is that the browser may select into the next element, even though this selection is not visible.
The selection may be:
anchorNode: p
anchorOffset: 0
focusNode: h2
focusOffset: 0
Even though h2 is technically selected, it is not really because the offset is 0.
We can adjust this in the selection extraction: just return the previous element if the offset is 0 and the direction is forward.
Testing Instructions
Particularly in Chrome:
Have a paragraph and some block like another paragraph or heading following. Triple click in the first block. It should not select multiple blocks (check the inspector).
Testing Instructions for Keyboard
Screenshots or screencast