Slash Inserter: Restrict block list to allowed blocks only#64413
Slash Inserter: Restrict block list to allowed blocks only#64413talldan merged 1 commit intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @ssang. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @ssang! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
talldan
left a comment
There was a problem hiding this comment.
The fix is working for me, and it seems like the intended use of the isQuick param.
Thanks again for spotting and fixing the bug.
Unlinked contributors: ssang. Co-authored-by: talldan <talldanwp@git.wordpress.org>
|
I've confirmed that the bug is also in WordPress 6.6.1, so I've cherry picked this onto the |
|
Thanks for the quick turnaround. Glad to see it fast forwarded to 6.6.2. I linked my account to WP if that affects anything. But that doesn't really matter :D |
Unlinked contributors: ssang. Co-authored-by: talldan <talldanwp@git.wordpress.org>
What?
Fixes #64411
This PR forces the
WPCompleterblock list to show insertable blocks only and fixes a regression introduced by #62169.Why?
See #64411
#62169 enabled all blocks to be visible in the block list. The
WPCompletercomponent should be restricted to relevant blocks like theQuickInserterHow?
afa0d6e added a
isQuickparameter to theuseBlockTypesState()call to restrict the quick inserter to a list of relevant blocks. Setting this to true when used in theWPCompletercomponent forces it to act like aQuickInsterterand only shows relevant blocks.Testing Instructions
core/paragraphblock as child blocks/to start searching for other blocksScreenshots or screencast
Before Gutenberg version 18.5.0
Gutenberg version ^18.5.0