Skip to content

Blocks: Remove backward compatibility solution for focus#6352

Merged
gziolo merged 1 commit intomasterfrom
update/remove-backward-compatibility-block-edit
Apr 24, 2018
Merged

Blocks: Remove backward compatibility solution for focus#6352
gziolo merged 1 commit intomasterfrom
update/remove-backward-compatibility-block-edit

Conversation

@gziolo
Copy link
Copy Markdown
Member

@gziolo gziolo commented Apr 23, 2018

Description

Raised by @noisysocks in #6312 (comment):

Unrelated, but maybe we should deprecate focus and setFocus more formally, e.g. calling deprecated and removing the functionality in two minor versions.

but clarified by @youknowriad:

I guess we didn't include those originally because there was no direct alternative. We did several releases since this change, I think we can just remove it on the next release or so.

This was already deprecated when isSelected property was introduced a few releases back.

This PR removed no longer used code and all related comments.

How has this been tested?

Manually. I tested with the demo post and other tests posts and everything worked as expected. It shouldn't be an issue with core blocks anymore. I refactored all existing blocks.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added the [Feature] Blocks Overall functionality of blocks label Apr 23, 2018
@gziolo gziolo added this to the 2.8 milestone Apr 23, 2018
@gziolo gziolo self-assigned this Apr 23, 2018
@gziolo gziolo changed the title Blocks: Remove backward compatibility for focus Blocks: Remove backward compatibility solution for focus Apr 23, 2018
Copy link
Copy Markdown
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@gziolo gziolo merged commit edb20ed into master Apr 24, 2018
@gziolo gziolo deleted the update/remove-backward-compatibility-block-edit branch April 24, 2018 06:29
nuzzio pushed a commit to nuzzio/gutenberg that referenced this pull request Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Blocks Overall functionality of blocks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants