Env: Remove version field from docker-compose config#63099
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @alessandrotesoro. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +292 B (+0.02%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
dmsnell
approved these changes
Jul 3, 2024
Member
dmsnell
left a comment
There was a problem hiding this comment.
Looks good once the remaining tests complete. Thanks for identifying the problem and fixing it. The release note could indicate why this was removed, but it's probably good enough on its own.
|
Flaky tests detected in 868c47f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9780588492
|
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Unlinked contributors: alessandrotesoro. Co-authored-by: ockham <bernhard-reiter@git.wordpress.org> Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: dmsnell <dmsnell@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove the
versionfield that's written to thedocker-compose.config.ymlfile generated by the env package.Fixes #63073.
Why?
The field is obsolete and has started causing automated tests to fail (due to a warning about it being obsolete), see e.g https://github.com/WordPress/gutenberg/actions/runs/9776598064/job/26989677669?pr=62092.
We have some precedent for this in
wordpress-develop, see#61101and WordPress/wordpress-develop#6492.How?
By removing that field 🤷♂️
Testing Instructions
Verify that tests pass in CI. Alternatively, try locally. You might want to destroy your current wp-env setup and recreate it.