Do not auto save post status changes#62171
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
|
Thanks, Nik! This reminded me of this issue - #56881. |
|
Size Change: -1 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Contributor
Author
Hm.. that's interesting and an easy change to do if we want to resolve that issue. Unfortunately I have no context at all about this logic, so I'll ping @WordPress/gutenberg-core for possible insights. I'm wondering if it had something to with the first versions of site editor that was using auto-drafts.. Having said that, I don't think this is a blocker for this PR. |
Contributor
|
This is working for me 👍 |
Mamaduka
approved these changes
May 31, 2024
Mamaduka
left a comment
Member
There was a problem hiding this comment.
Definitely not a blocker. The issue can be resolved separately when we have more context around the current (auto-draft to draft) behavior.
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org>
This was referenced Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Found by @Mamaduka here:
With autosaves we only update very specific attributes (handled above my changes here). The exception was only for when creating a new post (initial status
auto-draft) to make the statusdraft. Previously there was no specificpost statuspanel to edit the attribute directly, so it was safe to just use the saved post status, but it seems we don't need to make that update in any other case.Steps to reproduce
window.wp.data.dispatch( 'core/editor' ).autosave().Testing Instructions