Skip to content

Script Modules: Adjust filter and ID#62170

Merged
sirreal merged 2 commits intotrunkfrom
update/script-module-data-tweaks
Jun 4, 2024
Merged

Script Modules: Adjust filter and ID#62170
sirreal merged 2 commits intotrunkfrom
update/script-module-data-tweaks

Conversation

@sirreal
Copy link
Copy Markdown
Member

@sirreal sirreal commented May 31, 2024 •
edited
Loading

What?

Update the Script Module data filter and script tag ID to align with WordPress/wordpress-develop#6682.

This feature was just implemented in Gutenberg and not yet released, but Core feedback has suggested some changes to the filter name and script tag ID used.

Why?

If the initial version uses the filter and script tag IDs that will ultimately be used in Core, it should save work in the future.

@sirreal sirreal mentioned this pull request May 31, 2024
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 31, 2024

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/experimental/script-modules.php

@sirreal sirreal force-pushed the update/script-module-data-tweaks branch from 4b4db3a to d8c0e58 Compare June 3, 2024 16:23
@sirreal sirreal marked this pull request as ready for review June 3, 2024 16:57
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 3, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@sirreal sirreal added Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) [Type] Task Issues or PRs that have been broken down into an individual action to take labels Jun 3, 2024
@sirreal sirreal requested a review from gziolo June 3, 2024 17:18
@sirreal sirreal merged commit bbf0816 into trunk Jun 4, 2024
@sirreal sirreal deleted the update/script-module-data-tweaks branch June 4, 2024 05:41
@github-actions github-actions bot added this to the Gutenberg 18.6 milestone Jun 4, 2024
carstingaxion pushed a commit to carstingaxion/gutenberg that referenced this pull request Jun 4, 2024
@sirreal @gziolo @carstingaxion
Script Modules: Adjust data filter name and script tag ID (WordPress#…
d4b7217 
…62170)

Update the Script Module data filter name and script tag ID to align with Core changes.

See WordPress/wordpress-develop#6682.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
@sirreal sirreal modified the milestones: Gutenberg 18.6, Gutenberg 18.5 Jun 5, 2024
vcanales pushed a commit that referenced this pull request Jun 5, 2024
@sirreal @gziolo @vcanales
Script Modules: Adjust data filter name and script tag ID (#62170)
2fe4dfa 
Update the Script Module data filter name and script tag ID to align with Core changes.

See WordPress/wordpress-develop#6682.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
@vcanales
Copy link
Copy Markdown
Member

vcanales commented Jun 5, 2024

I just cherry-picked this PR to the release/18.5 branch to get it included in the next release: 2fe4dfa

@vcanales vcanales removed the Backport to Gutenberg RC Pull request that needs to be backported to a Gutenberg release candidate (RC) label Jun 5, 2024
@sirreal
Copy link
Copy Markdown
Member Author

sirreal commented Jun 6, 2024

I added the Backport to WP Beta/RC label here. The only backport necessary is the @wordpress/interactivity package that should be updated to the version released in the latest Gutenberg version 18.5.

ellatrix pushed a commit that referenced this pull request Jun 11, 2024
@sirreal @gziolo @ellatrix
Script Modules: Adjust data filter name and script tag ID (#62170)
83394a6 
Update the Script Module data filter name and script tag ID to align with Core changes.

See WordPress/wordpress-develop#6682.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
ellatrix pushed a commit that referenced this pull request Jun 11, 2024
@sirreal @gziolo @ellatrix
Script Modules: Adjust data filter name and script tag ID (#62170)
0846b5f 
Update the Script Module data filter name and script tag ID to align with Core changes.

See WordPress/wordpress-develop#6682.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
patil-vipul pushed a commit to patil-vipul/gutenberg that referenced this pull request Jun 17, 2024
@sirreal @gziolo @patil-vipul
Script Modules: Adjust data filter name and script tag ID (WordPress#…
58ed4b3 
…62170)

Update the Script Module data filter name and script tag ID to align with Core changes.

See WordPress/wordpress-develop#6682.

Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Co-authored-by: gziolo <gziolo@git.wordpress.org>
@ellatrix
Copy link
Copy Markdown
Member

ellatrix commented Jun 18, 2024

This was cherry-picked to the wp/6.6 branch.

@luisherranz luisherranz mentioned this pull request Jul 4, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gziolo gziolo gziolo approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@luisherranz luisherranz Awaiting requested review from luisherranz luisherranz is a code owner

@DAreRodz DAreRodz Awaiting requested review from DAreRodz DAreRodz is a code owner

Assignees

No one assigned

Labels

[Type] Task Issues or PRs that have been broken down into an individual action to take

Projects

None yet

Milestone

Gutenberg 18.5

Development

Successfully merging this pull request may close these issues.

4 participants

@sirreal @vcanales @ellatrix @gziolo