Enable shadow support for cover block#61883
Merged
Conversation
5 tasks
|
Flaky tests detected in bc517f0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9215617685
|
46425ba to
7de05db
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
25554a6 to
bc517f0
Compare
madhusudhand
approved these changes
May 25, 2024
Member
madhusudhand
left a comment
There was a problem hiding this comment.
Shadow applies to cover block both in global styles and block settings.
LGTM! 🚢
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103 Co-authored-by: vcanales <vcanales@git.wordpress.org> Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
bc517f0 to
770fa91
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: WordPress#57103 Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
vcanales
added a commit
that referenced
this pull request
Jun 11, 2024
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: #57103 Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be able to enable shadow support without any modifications to the block itself. I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this. Tracking issue: WordPress#57103 Co-authored-by: madhusudhand <madhudollu@git.wordpress.org>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
On previous attempts to do this, the cover block was displaying inconsistencies between how it was rendered in the editor vs the frontend; that doesn't seem to be the case anymore, so we should be enable shadow support without any modifications to the block itself.
I'd still appreciate some eyes on this, because I don't know what exactly has changed since the first time I attempted this.
Testing Instructions
Screenshots or screencast