useBlockSync: just testing without isControlled effect#61114
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -91 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Apr 25, 2024
| if ( ! isControlled ) { | ||
| pendingChanges.current.outgoing = []; | ||
| setControlledBlocks(); | ||
| } |
Contributor
There was a problem hiding this comment.
So now, I have a vague memory of the Navigation block switching between "not controlled" into "controlled" to support some legacy mode of that block. @draganescu might know more. I guess the testing instructions is to try to load that old navigation block markup in the editor and ensure that everything works as expected.
Contributor
There was a problem hiding this comment.
The navigation block can start as uncontrolled, when there are navigation inner blocks specified in the markup. When this uncontrolled state is updated by say adding a new navigation link, the content is saved to a CPT and the block switches to controlled.
EDIT:
I tested this PR and the functionality described above seems unaffected.
Member
There was a problem hiding this comment.
But the potentialy buggy part is when you hit Undo after this switch from uncontrolled to controlled. Then probably the navigation block should switch back to uncontrolled? And revert to the uncontrolled inner blocks specified in the markup?
That's what the title of #37484 (the PR that claims to fix #37361) says: "avoid undo issues"
Contributor
There was a problem hiding this comment.
the navigation block should switch back to uncontrolled?
I can't tell if that was ever the case? I don't even know if we want that, the uncontrolled version is just a way for themes to include default navigation content for style reasons.
Member
Author
|
So the PR that introduced this fixed #37361. I tried to reproduce the original issue, but maybe I'm doing it wrong. Edited the page content, then undo, but the header template contents are still there. Unfortunately there's no e2e test I think. |
jsnajdr
approved these changes
Apr 29, 2024
Member
jsnajdr
left a comment
There was a problem hiding this comment.
Yes, IMO the effect is guaranteed to never be called. The only place where isControlled can go from true to false is the cleanup effect function of useBlockSync, when the hook is unmounting. And at that time of unmounting and cleanup, no new effect will be scheduled.
Member
Author
|
Whoops, forgot to change the commit title 🤦♀️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Just checking what tests will fail, see #60967 (review)
Edit: ok, this passed 🙂
Edit: but it was first introduced in #37484 (fixing #37361), which didn't add any e2e tests. So we'll have to check that.
Why?
Reduce complexity
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast