Fix responsive column span logic on the front end.#60976
Fix responsive column span logic on the front end.#60976tellthemachines merged 1 commit intotrunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
fabiankaegy
left a comment
There was a problem hiding this comment.
This works as expected :)
|
Adding backport label so this fix can hopefully go into 18.2! Cc @colorful-tones |
|
Thanks for the heads up @tellthemachines. I'll do my best and follow the notes to cherry-pick this in, and of course, ask questions if I hit a snag. 👍 |
|
I just cherry-picked this PR to the release/18.2 branch to get it included in the next release: fd37383 |
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org>
What?
Fixes issue detected here where grid elements spanning multiple columns weren't correctly downsizing when the parent grid's
minimumColumnWidthwas a non-default value.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
This should be the expected behaviour for the example given in the original report:
grid-resize.mp4