Restore classic auto margin rule to its previous specificity.#60802
Merged
tellthemachines merged 1 commit intotrunkfrom Apr 18, 2024
Merged
Restore classic auto margin rule to its previous specificity.#60802tellthemachines merged 1 commit intotrunkfrom
tellthemachines merged 1 commit intotrunkfrom
Conversation
|
Size Change: -2 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
Contributor
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
andrewserong
approved these changes
Apr 18, 2024
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
This is testing nicely for me, resolves the issue in Twenty Twenty, and I didn't notice any regressions or other issues when testing with a range of random themes from the theme directory.
LGTM! ✨
ramonjd
approved these changes
Apr 18, 2024
Member
ramonjd
left a comment
There was a problem hiding this comment.
Twenty Twenty
| Before | After |
|---|---|
 |
 |
Apostrophe 2
| Before | After |
|---|---|
 |
 |
Also smoke tested block themes in site and post editors. Layout for these blocks LGTM.
Contributor
Author
|
Thanks for the reviews folks! |
Contributor
|
Appreciate the quick fix and reviews everyone, nice work! 🙇 |
arthur791004
pushed a commit
that referenced
this pull request
Apr 18, 2024
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: arthur791004 <arthur791004@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes bug introduced in #60154 and reported here. Themes relying on this rule for editor styles might have seen some inadvertent changes with the specificity reduction.
Testing Instructions
Note: in testing this I noticed that the auto margin rule is causing a discrepancy between editor and front-end in the Details block on both Twenty Twenty and TT1, but that's likely due to those themes not having targeted styles for that block such as they do for older blocks like Columns. It remains an issue regardless of the specificity of this rule, so shouldn't be a blocker for this PR.
Testing Instructions for Keyboard
Screenshots or screencast