Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +7 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ntsekouras
approved these changes
Apr 2, 2024
Contributor
ntsekouras
left a comment
There was a problem hiding this comment.
I'm wondering if it would be better to update view.hiddenFields based on the existence of special layout fields (ex. mediaField), but since these fields and their handling might change, I think it's good to land for now. Thanks!
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55083
Extracted from #60069
What?
The deferred rendering mechanism is used in templates when the
previewfield is visible. This renders template items in batches of 3. However, we've missed that the preview is always visible in the grid layout.This PR activates deferred loading when the grid layout is in use as well:
Gravacao.do.ecra.2024-04-02.as.12.45.07.mov
How?
deferredRenderingshould be active when the preview field is present or the grid layout is in use (that contains previews). d593443Testing Instructions
Visit the Templates page and switch to the grid layout. Verify items load in batches of 3.