Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Apr 1, 2024
| const EMPTY_ARRAY = []; | ||
| const defaultConfigPerViewType = { | ||
| [ LAYOUT_TABLE ]: { | ||
| primaryField: 'title', |
Contributor
There was a problem hiding this comment.
What's the primary field of a "table" layout? What's different from regular fields?
Member
Author
|
Size Change: +1.27 kB (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
I like the inclusion of this view, but am more curious about the orange color I am seeing in the screenshots. Are those Figma mockups, or is there a setting somewhere that I may have missed for accent colors? |
Member
Author
It's a admin color schema for the test user that I use. I've been using it since a few months ago to make sure the dataviews work is admin-color-schema friendly (this raised a couple of bugs with links, for example). |
youknowriad
approved these changes
Apr 1, 2024
Member
Author
|
One thing I've noticed when testing selection in this PR is that:
Gravacao.do.ecra.2024-04-01.as.13.33.59.mov
Gravacao.do.ecra.2024-04-01.as.13.30.47.movI can reproduce both things in Templates/Parts, so it should be addressed in a separate PR. |
33 tasks
Member
Author
|
Merging this one to continue work, happy to do any follow-ups. |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: bgardner <bgardner@git.wordpress.org>
This was referenced Apr 12, 2024
This was referenced Jul 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #55083
Related #59659
What?
Enables the
tablelayout for the Patterns page.When clicking the preview or the title for user-provided patterns, it goes directly to the editor instead of visiting the details page:
Gravacao.do.ecra.2024-04-01.as.17.03.21.mov
Why?
It's part of the design goal, see #59659
How?
tablelayout and sets itsprimaryFieldb59dcd4Testing Instructions
Visit Patterns page and switch to table layout via the view actions menu.
TODO