Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
commented
Mar 28, 2024
Comment on lines
+81
to
+84
| const isSynced = | ||
| isReusableBlock( blockType ) || isTemplatePart( blockType ); | ||
| const syncedTitle = isSynced | ||
| ? getBlockLabel( blockType, attributes ) |
Member
Author
There was a problem hiding this comment.
The template part has a similar __experimentalLabel handler, so I unified the logic.
|
Size Change: +7 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
ellatrix
approved these changes
Mar 30, 2024
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
WordPress#60278) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This is a follow-up #58646.
PR deprecates the
__experimentalGetReusableBlockTitleselector and removes its usage from theuseBlockDisplayInformationhook.Why?
Now that the Pattern block uses the
__experimentalLabelmethod for labels, there's no need to keep the selector around.Testing Instructions
wp.data.select( 'core/block-editor' ).__experimentalGetReusableBlockTitle( patternRef );Testing Instructions for Keyboard
Same.
Screenshots or screencast