Allow blocks to be grouped as a Grid#59853
Merged
tellthemachines merged 1 commit intotrunkfrom Mar 14, 2024
Merged
Conversation
|
Size Change: +3 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
andrewserong
approved these changes
Mar 14, 2024
Contributor
andrewserong
left a comment
There was a problem hiding this comment.
Nice simple PR 👍
2024-03-14.15.27.01.mp4
This feels really good to use to me, especially when paired with the on canvas grid interactions, this feels like it's going to unlock some powerful flows 🎉
LGTM! ✨
| { canInsertGrid && ( | ||
| <ToolbarButton | ||
| icon={ grid } | ||
| label={ _x( 'Grid', 'verb' ) } |
Contributor
There was a problem hiding this comment.
This was a TIL for me, I didn't realise that grid could be used as a verb: https://en.wiktionary.org/wiki/grid#Verb. Nice!
Contributor
Author
There was a problem hiding this comment.
I wondered if the use here is clear enough? But the alternative would be a verbose or potentially confusing description like "configurable rows and columns". I guess ultimately what matters is if the meaning is sufficiently clear to translators; grid as a verb is unlikely to exist in every language.
Contributor
There was a problem hiding this comment.
I think it's probably fine for now, particularly since it'd be an easy thing to update. I suppose another option would be to use __( 'Grid' ) with no explanatory comment, to default to a noun 🤔
Contributor
Author
There was a problem hiding this comment.
I'll leave it as is for now.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Contributor
|
Thank you |
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: tellthemachines <isabel_brison@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org>
14 tasks
mcsf
added a commit
that referenced
this pull request
Oct 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Another step towards #57478.
Allows a selection of multiple blocks to be grouped as a Grid.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
grid.mov