Fixed the font family modal to open in state when a font is already selected.#59379
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
matiasbenedetto
approved these changes
Feb 27, 2024
matiasbenedetto
left a comment
Contributor
There was a problem hiding this comment.
This is working as advertised.
Before:
2024-02-26.13-18-18.mp4
After:
2024-02-27.08-06-01.mp4
LGTM.
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…elected (#59379) Co-authored-by: pbking <pbking@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 78a4740 |
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
…elected (#59379) Co-authored-by: pbking <pbking@git.wordpress.org> Co-authored-by: matiasbenedetto <mmaattiiaass@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When a Font Family has been selected BEFORE the Font Library Modal has been opened (for instance when clicking on one of the font families here:)
the modal should open to the
font family detailspanel.Why?
This fixes breakage introduced in #59036 (comment)
How?
Set the 'initial path' of the Navigator based on a font being already selected or not.
Testing Instructions
Click on a Font in the 'Fonts' list in Global Styles.
The Font Library panel should open to the font you just clicked
It should otherwise work as it had.