Cover block: Clear aspect ratio value when toggling full height#59296
Merged
andrewserong merged 2 commits intoFeb 25, 2024
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +33 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
fabiankaegy
approved these changes
Feb 23, 2024
fabiankaegy
left a comment
Member
There was a problem hiding this comment.
Good catch and works as advertised :)
Should we backport this to 6.5? Seems like a bug that was introduced with the newly inroduced aspect ratio on the cover
jasmussen
approved these changes
Feb 23, 2024
jasmussen
left a comment
Contributor
There was a problem hiding this comment.
Fabian beat me to it, but I want to also thank you for tackling this one! 🙏
Contributor
Author
|
Thanks for the reviews, folks! 🙇
Yes, that's the intention. Thanks for adding the labels! |
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Cover block: Clear aspect ratio value when toggling full height * Tweak isMinFullHeight logic Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 5191efd |
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Cover block: Clear aspect ratio value when toggling full height * Tweak isMinFullHeight logic Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix an issue with the Cover block where if an aspect ratio is set, the Full Height toggle button in the block toolbar wasn't working.
Why?
Aspect ratio takes precedence over min height rules in the Cover block, so if we wish to update the min height rules, we need to clear out the aspect ratio value.
How?
In the cover block controls, when toggling the full height, clear out the aspect ratio value. Also, only show the full height control as "on" if there is no aspect ratio value.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before
2024-02-23.12.31.17.mp4
After
2024-02-23.12.31.57.mp4