Update pages dataview icons, add 'drafts' icon#59285
Merged
Merged
Conversation
|
Size Change: +346 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
approved these changes
Feb 22, 2024
t-hamano
left a comment
Contributor
There was a problem hiding this comment.
The new drafts icon makes sense to me. The icon with a pencil might be used for actions such as "Edit Page/Edit Page" in the future.
Below are the page icon variations in the dashicon:
Contributor
Author
|
Thanks y'all. I'll merge this as it's an improvement on trunk, and we can revisit the drafts icon if a better idea arises. |
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: d59ab95 |
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Update the decorative icon assigned to the "All pages" and "Drafts" page views.
Why?
The current
blockTableicon doesn't communicate context in the same way the Trash icon does. This change aligns the icon purpose across the buttons.How?
A new
draftsicon has been added to the library. This is an initial take on the design amongst several explorations:The appearance and name of this icon can be discussed further in this PR.