Update filter control position#59231
Merged
Merged
Conversation
|
Size Change: -14 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
SaxonF
approved these changes
Feb 21, 2024
SaxonF
left a comment
Contributor
There was a problem hiding this comment.
Looks like a good improvement to me. I'm assuming majority of cases will have one or two filters. Nice work.
|
Flaky tests detected in e353e9d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8017782201
|
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: SaxonF <saxonafletcher@git.wordpress.org>
Contributor
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: eadfe88 |
9 tasks
getdave
pushed a commit
that referenced
this pull request
Feb 27, 2024
Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: SaxonF <saxonafletcher@git.wordpress.org>
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR moves the data view filter controls into the same row as the search, bulk actions, and view options controls.
Why?
When no (or few) filters are set (which is most common), two separate rows for these controls doesn't feel like the best use of space.
The trade-off is that on smaller screens the controls move around when you begin adding lots of filters. However, for 6.5 core data views have at most two filters, so this feels a bit of an edge case. In the future filter controls may permanently require a dedicated row, but I'm not sure that's the case right now.
Testing Instructions
filters.mp4