Editor: Fix post type check in isEditingTemplate selector#59105
Conversation
…d of `post-only`
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mattgrshaw! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
youknowriad
left a comment
There was a problem hiding this comment.
Yes, sorry, my mistake here.
|
Seeing approvals for this PR and that it's ready to squash and merge. Proceeded with doing so in order to get into 6.5! |
|
I just cherry-picked this PR to the cherry-pick-wp-6-5-beta-3 branch to get it included in the next release: 8646cd1 |
What?
This PR fixes what seems to be an invalid check in
isEditingTemplatethat was causing it to returntrue, even when not editing a template.Why?
ACF was using this selector to check if a template was currently being edited instead of a standard post. It looks like this has been deprecated, but in WP 6.5-beta1 it seems to always return
true, which could cause issues for plugins that haven't updated their code.How?
isEditingTemplatenow checks for thewp_templatepost type instead ofpost-only.Testing Instructions
isEditorTemplateselector in a standard post or page. It seems to always returntrue.false, but still returnstruewhen editing a template (via the sidebar -> Post -> Template dropdown -> Create new template)Screenshots or screencast