Image block: refactor and remove data-wp-body#58835
Merged
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -912 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Member
Author
|
It looks like this PR refactoring reduced the size of the JS code of the lightbox by 25% 🙂 |
|
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
47 tasks
Member
Author
|
This is ready. We saw a couple of bugs in Safari that are already present in
|
SantosGuillamot
approved these changes
Feb 9, 2024
SantosGuillamot
left a comment
Contributor
There was a problem hiding this comment.
Great refactoring! 👏 Glad to see that we are sending less JS and HTML to the browser 🙂
I've been testing it on Chrome, Safari, iPhone, and Android, and everything seems to be working as previously.
dan-zakirov
added a commit
to dan-zakirov/gutenberg
that referenced
this pull request
Apr 19, 2026
…toggles Renders the inline caption inside the lightbox overlay (hidden since PR WordPress#58835 shipped in WordPress 6.5) and adds two Gallery-level toggles so authors can control where captions appear. Image block: - Extract caption in `block_core_image_render_lightbox()` and pass it to the Interactivity API state (plain text via `wp_strip_all_tags`). - Add a `<figcaption class="wp-lightbox-caption">` inside the overlay template, bound via `data-wp-text`. - New `block_core_image_apply_gallery_caption_visibility()` filter to strip the inline caption when the parent Gallery opts out. Gallery block: - New `showCaptionInGallery` and `showCaptionInLightbox` optional attributes exposed via `providesContext`. - New `Captions` section in the Settings panel with two toggles. Styles fade the overlay caption in after the zoom animation settles, with `prefers-reduced-motion` disabling the transition. This unblocks the WordPress.org Plugin Directory screenshot migration (WordPress/wordpress.org#524, meta#8083). A follow-up PR is planned for per-image overrides. Fixes WordPress#60469
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the use of
data-wp-bodydirective in the Image block. It also refactors the logic a bit to clean up the code, and reduce the size of the JavaScript file.Why?
Because the Interactivity API won't include the
data-wp-bodydirective in the WP 6.5 version.How?
By replacing the
data-wp-bodywith awp_footerfilter that prints only one lightbox overlay for all the images.Testing Instructions