Aspect ratio: remove support on the Group block for now#58414
Merged
andrewserong merged 1 commit intotrunkfrom Jan 29, 2024
Merged
Aspect ratio: remove support on the Group block for now#58414andrewserong merged 1 commit intotrunkfrom
andrewserong merged 1 commit intotrunkfrom
Conversation
|
Flaky tests detected in 60fbfd0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7702692781
|
noisysocks
approved these changes
Jan 29, 2024
Contributor
Author
|
Thanks for the quick review, Rob! 🙇 |
Contributor
|
Thank you! We can potentially explore re-enabling this in the future depending on how it works in the Cover block. But for now, the Cover with the DNA it shares with Image, means the two are sides of a coin and it's a good fit there. |
cbravobernal
pushed a commit
that referenced
this pull request
Jan 30, 2024
Contributor
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 7ec2d92 |
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Following on from feedback on #56897, let's remove aspect ratio support from the Group block for now.
Why?
Aspect ratio support is a natural fit for the Cover block where folks are actively using min-height controls and the block has a default min height, with everything centred by default. With the Group block, positioning controls aren't exposed by default, and the use case for aspect ratio there is quite nuanced (likely only really works well with particular Row and Stack blocks, and depending on the kind of contents in use)
So, until we have a solid use case for re-enabling it and/or a good way to hide the control until it's really needed, this PR proposes leaving Group block without aspect ratio support for WP 6.5. This will give us a bit more time to consider whether or not it should be included with the Group block further down the track, as it will be much easier to re-add the control than to remove it once it's in a major release.
How?
block.jsonfile to remove aspect ratio supportTesting Instructions
Testing Instructions for Keyboard
Screenshots or screencast