Font Library: addresses additional REST API feedback#58333
Merged
creativecoder merged 2 commits intotrunkfrom Jan 29, 2024
Merged
Font Library: addresses additional REST API feedback#58333creativecoder merged 2 commits intotrunkfrom
creativecoder merged 2 commits intotrunkfrom
Conversation
Merged
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/experimental/fonts/font-library/class-wp-rest-font-faces-controller.php ❔ lib/experimental/fonts/font-library/class-wp-rest-font-families-controller.php ❔ lib/experimental/fonts/font-library/font-library.php |
18ee654 to
1388bec
Compare
mikachan
approved these changes
Jan 29, 2024
Member
mikachan
left a comment
There was a problem hiding this comment.
I believe this addresses the feedback left in #57688 (review). I can also confirm that only an admin user can access the font family and font face endpoints.
Contributor
|
I just cherry-picked this PR to the release/17.6 branch to get it included in the next release: 2f702c3 |
youknowriad
pushed a commit
that referenced
this pull request
Jan 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Addresses additional feedback from this review.
gutenberg_convert_legacy_font_family_format)get_item_permissions_checkon font family and font face controllers.Testing Instructions