Ensure Term Description block is registered in core#55669
Merged
Conversation
Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active.
|
Flaky tests detected in 7bff62c. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6671034389
|
luisherranz
approved these changes
Oct 27, 2023
Member
There was a problem hiding this comment.
I agree that reverting #51053 to solve the regression for WP 6.4, and address the original problem in a future PR instead, sounds like the best solution 🙂
SiobhyB
added a commit
that referenced
this pull request
Oct 27, 2023
Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active.
Contributor
Author
|
Noting for posterity that this has been cherry-picked for inclusion in 6.4 in fe0bbd8, including as it fixes a breaking change that was introduced in 6.4. |
SiobhyB
added a commit
that referenced
this pull request
Oct 28, 2023
* Patterns: set context of pattern category api call to view so authors and contributors can access (#55553) * Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539) * Update useContainsThirdPartyBlocks and texts * Improve texts a bit * Show the list of unsupported blocks * Use the BlockTitle component instead * Simplify modal text * Revert "Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539)" This reverts commit f2dd6de. * Query Loop: Disallow "enhanced pagination" with core blocks that may contain third-party blocks (#55539) * Update useContainsThirdPartyBlocks and texts * Improve texts a bit * Show the list of unsupported blocks * Use the BlockTitle component instead * Simplify modal text * Revert CSS changes to show/hide embedded pdf (#55667) * Ensure Term Description block is available in core (#55669) Reverts changes in #51053, to address a regression in which the Term Description block was only available in core when the Gutenberg plugin was active. --------- Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: David Arenas <david.arenas@automattic.com>
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: #5587. This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. git-svn-id: https://develop.svn.wordpress.org/trunk@57034 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to WordPress/WordPress
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: WordPress/wordpress-develop#5587. This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. Built from https://develop.svn.wordpress.org/trunk@57034 git-svn-id: http://core.svn.wordpress.org/trunk@56545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: WordPress/wordpress-develop#5587. This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. Built from https://develop.svn.wordpress.org/trunk@57034 git-svn-id: https://core.svn.wordpress.org/trunk@56545 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: #5587 This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Reviewed by helloFromTonya. Merges [57034] to the 6.4 branch. Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. git-svn-id: https://develop.svn.wordpress.org/branches/6.4@57035 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Oct 31, 2023
The npm packages needed update for 6.4 RC3. Patch: WordPress/wordpress-develop#5587 This PR includes the following changes: - Regression: [WordPress/gutenberg#55553 Patterns: fix bug with authors and contributors not seeing user pattern categories]. - Bugfix: [WordPress/gutenberg#55539 Query Loop:Disallow "enhanced pagination" with core blocks that may contain third-party blocks]. - Regression: [WordPress/gutenberg#55667 File: Fix embedded PDF files in Safari]. - Regression: [WordPress/gutenberg#55669 Ensure Term Description block is registered in core] Reviewed by helloFromTonya. Merges [57034] to the 6.4 branch. Props DAreRodz, luisherranz, poena, afercia, danieldudzic, hellofromtonya, siobhyb, mikachan, get_dave, scruffian, wildworks, glendaviesnz, ramonopoly, aaronrobertshaw. See #59411. Built from https://develop.svn.wordpress.org/branches/6.4@57035 git-svn-id: http://core.svn.wordpress.org/branches/6.4@56546 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
With this PR, changes are made so that the Term Description block (
core/term-description) is available in core without the need to install the Gutenberg plugin.Why?
As per #55665, 6.4-RC2 saw a breaking change in which the Term Description block was no longer available within the full-site editor. This regression was introduced in #51053.
How?
Due to the urgency of this fix, this PR simply reverts #51053 so that the Term Description block is not completely broken without the Gutenberg plugin installed.
The original bug, in which the block is available in places it shouldn't be (i.e. the post editor), can be addressed separately to this PR. The thinking here is as follows:
Testing Instructions
Testing Instructions for Keyboard
N/A