Columns block: fix arrow up into it#55197
Merged
Merged
Conversation
|
Size Change: +174 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f54560f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6467783207
|
jorgefilipecosta
approved these changes
Oct 10, 2023
jorgefilipecosta
left a comment
Member
There was a problem hiding this comment.
The code looks good and worked well on the test I did 👍
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
Nice fix! This is testing well for me manually, too.
I tried kicking off the e2e tests again, but they're still failing. From the error message, I think some other tests might need updating as one of the checks for the Add block button now resolves to two elements instead of one, since opacity is being used instead of visibility?
Here's the error message:
1) [chromium] › editor/various/writing-flow.spec.js:24:2 › Writing Flow (@Firefox, https://github.com/WebKit) › Should navigate inner blocks with arrow keys
Error: locator.click: Error: strict mode violation: locator('role=button[name="Add block"i]') resolved to 2 elements:
1) <button type="button" aria-haspopup="true" aria-expanded…>…</button> aka getByRole('document', { name: 'Block: Column (1 of 2)' }).getByRole('button', { name: 'Add block' })
2) <button type="button" aria-haspopup="true" aria-expanded…>…</button> aka getByRole('document', { name: 'Block: Column (2 of 2)' }).getByRole('button', { name: 'Add block' })
In the WritingFlowUtils class, the addDemoContent function looks for the add block button here:
Add block button that is a child of the particular column block?
f54560f to
b08890d
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
pushed a commit
to garridinsi/gutenberg
that referenced
this pull request
Apr 9, 2024
Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: jorgefilipecosta <jorgefilipecosta@git.wordpress.org> Co-authored-by: andrewserong <andrewserong@git.wordpress.org> Co-authored-by: jeryj <jeryj@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #51554. This is a regression caused by #43513. Cc @jasmussen
Why?
How?
Fixed by using opacity instead.
visibility: noneprevents the browser from setting focus. Additionally, it should be visible when the inserter button is focussed.Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast