Global Styles: Fix push to global styles for 6.3.x#53624
Merged
tellthemachines merged 1 commit intowp/6.3from Aug 15, 2023
Merged
Global Styles: Fix push to global styles for 6.3.x#53624tellthemachines merged 1 commit intowp/6.3from
tellthemachines merged 1 commit intowp/6.3from
Conversation
|
Size Change: +426 B (0%) Total Size: 1.46 MB
ℹ️ View Unchanged
|
aaronrobertshaw
commented
Aug 15, 2023
Contributor
Author
aaronrobertshaw
left a comment
There was a problem hiding this comment.
I've given this a test following the instructions in #51621 and I think it's ready for some reviews.
| ]; | ||
| const value = presetAttributeValue | ||
| ? `var:preset|${ STYLE_PATH_TO_CSS_VAR_INFIX[ presetAttributeKey ] }|${ presetAttributeValue }` | ||
| : get( attributes.style, path ); |
Contributor
Author
There was a problem hiding this comment.
The original PR uses a new custom util (getValueFromObjectPath) to avoid the lodash use that was present in this file for 6.3.
tellthemachines
approved these changes
Aug 15, 2023
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the PR! Code looks good and the fix is working as expected ✅
Contributor
|
I'm going to revert this PR temporarily so we can get a package update out with only the fixes for the editor crash issues, as per @azaozz's suggestion. Once that update is done, we can re-merge this so it goes into 6.3.2. |
tellthemachines
added a commit
that referenced
this pull request
Aug 16, 2023
This reverts commit 46dc7f0.
tellthemachines
added a commit
that referenced
this pull request
Aug 16, 2023
ramonjd
pushed a commit
that referenced
this pull request
Aug 30, 2023
Closed
Member
|
I just cherry-picked this PR to the bugfixes/wp-6.3.2 branch to get it included in the next minor release 🤞🏻 . |
tellthemachines
added a commit
that referenced
this pull request
Aug 31, 2023
tellthemachines
added a commit
that referenced
this pull request
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
What?
Brings the fixes for the "push to global styles" feature from #51621 to WP 6.3 for a point release.
Why?
Without these fixes the "push to global styles" feature is broken;
How?
Copies fixes from #51621 without the lodash removal, behaviors, etc.
Testing Instructions
In essence, ensure that: