Merged
Conversation
|
Size Change: +9 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in f838e3be94ad10cc4057cba36aee96adae2c5e6b. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5623022444
|
f838e3b to
698e16f
Compare
ef15538 to
541ac2d
Compare
541ac2d to
cc4a9be
Compare
cc4a9be to
6941041
Compare
Contributor
|
Testing well! On 
On this PR it's working well without any errors 👍🏻 
|
jeryj
approved these changes
Jul 21, 2023
Contributor
jeryj
left a comment
There was a problem hiding this comment.
Testing well and fixes the mentioned issue!
scruffian
approved these changes
Jul 21, 2023
Contributor
scruffian
left a comment
There was a problem hiding this comment.
LGTM. Well done for finding this. 👏
Member
|
Nice work, thank you 🙏 Now we know who to come to for deprecation troubleshooting |
Member
|
I noticed another issue with the deprecation. Here's a follow-up #52853. |
Member
|
@draganescu, do we need to backport this and #52853, into 6.3 RC? Edit: I tentatively added the backported labels, as I noticed this PR was already tagged in a project. |
Contributor
|
I just cherry-picked this PR to the update/further-bugfixes-rc2 branch to get it included in the next release: 0c46818 |
tellthemachines
pushed a commit
that referenced
this pull request
Jul 25, 2023
* Remove incorrect comment * Add missing attribtes and supports * Add integration tests for the deprecation * Fix incorrect import * Fix fixtures
ramonjd
added a commit
that referenced
this pull request
Jul 25, 2023
* Fix image block v6 deprecation (#52822) * Remove incorrect comment * Add missing attribtes and supports * Add integration tests for the deprecation * Fix incorrect import * Fix fixtures * Image: Use the correct method for caption class in recent deprecation (#52853) * Distraction Free: Fix notices in site editor (#52867) * Distraction Free: Add missing command in site editor (#52868) * Site Editor: Fix the template parts link on the list page (#52891) * Return focus more from focus return hook (#52710) * Disambiguate "Import" button string. (#52907) * Disambiguate "Import" button string. * Add _x to import --------- Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> * My patterns page: Increase color contrast for the toggle group (#52678) * Update style.scss * Update style.scss * Check if object exists before accessing its properties. (#52870) * Check if object exists before accessing its properties. * Name anonymous functions * Update names * Sidebar: Restore Back buton 'go to parent' functionality (#52910) * Global styles revisions: display text if no revisions are found (#52865) * If somehow a user lands on the revisions panel when there are no revisions, show some helpful text rather than a loading spinner. Also, add an E2E test! * Updated unit tests to reflect resolver logic changes * Use existing string * Only open edit view when testing the revisions panel itself * ResizableFrame: Account for window resizing (#52697) * ResizableFrame: Account for window resizing * Don't memoize --------- Co-authored-by: Robert Anderson <robert@noisysocks.com> * Distraction Free: Fix conflict with showListViewByDefault preference (#52914) * Backporting changes from WordPress/wordpress-develop#4891 * Site Editor: Open template parts in view canvas view mode (#52916) --------- Co-authored-by: Alex Lende <alex+github.com@lende.xyz> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Mitchell Austin <mr.fye@oneandthesame.net> Co-authored-by: Jb Audras <audrasjb@gmail.com> Co-authored-by: Carolina Nymark <myazalea@hotmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Lena Morita <lena@jaguchi.com> Co-authored-by: ramon <ramonjd@gmail.com>
mburridge
pushed a commit
that referenced
this pull request
Jul 26, 2023
* Remove incorrect comment * Add missing attribtes and supports * Add integration tests for the deprecation * Fix incorrect import * Fix fixtures
Contributor
|
I just cherry-picked this PR to the release/16.3 branch to get it included in the next release: bf38308 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes an image block deprecation issue surfaced in #52388 (comment). I'm not sure if it really solves the original issue because the page should load despite block validation errors.
Why?
Bug fix
How?
getBorderClassesAndStylesimport.attributesandsupportsto the deprecation.Testing Instructions
Integration tests have been added for the deprecation. They should pass.
To manually test, add a v6 image block to a post via the code editor and save:
You should no longer see the deprecation warning.
Testing Instructions for Keyboard
Screenshots or screencast