Improve consistency of the Post editor and Site editor Document actions#52246
Merged
Improve consistency of the Post editor and Site editor Document actions#52246
Conversation
Contributor
Author
|
The code changes in this PR are simple enough. I'd appreciate some eyes on the CSS changes part. Cc @jasmussen |
|
Size Change: -28 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
carolinan
reviewed
Jul 5, 2023
Contributor
carolinan
left a comment
There was a problem hiding this comment.
I followed the testing instructions and the changes work well for me.
I did not screenshot everything, but here are two focus styles:
Site Editor focus style
Post editor, template editing, back button in focus:
f3480eb to
65fd4b2
Compare
65fd4b2 to
2b67b2b
Compare
tellthemachines
approved these changes
Jul 27, 2023
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Code LGTM.
I'm guessing the labelling issue will be addressed in a separate PR? It's a complicated one as long as the button is also acting as a page title.
Contributor
|
I think we should add this to 6.3 given the document actions button is a new feature for this release, and this fixes a most annoying bug. |
|
Contributor
Author
Yes the fact the button is also acting as a page title is not ideal and it's a problem that will likely need some discussion to be solved. I'd suggest to keep #51460 and #51729 open. Thank you for the review! |
ramonjd
pushed a commit
that referenced
this pull request
Jul 28, 2023
…ns (#52246) * Remove redundant shortcut button. * Fix focus and hover style and improve consistency. * Rename post document-title and improve CSS consistency.
Member
|
I just cherry-picked this PR to the update/packages-wp-6-3-RC3 branch to get it included in the next release: a44342f |
ramonjd
added a commit
that referenced
this pull request
Jul 28, 2023
* Patterns: Enable focus mode editing (#52427) * PreventDefault when isComposing is true. apply patch from t-hamano. (#52844) see: #52821 (comment) * List View: Ensure onDrop does not fire if there is no target (#52959) * I18N: Add missing Gettext wrapper on strings in Edit Post overview sidebar (#52971) * I18N: Add missing gettext wrapper * Add context to disambiguate 'Outline' that is commonly used on borders. * Footnotes: disable based on post type (#52934) * Footnotes: disable based on post type * Address feedback * Fix typo * Format: disable if block is not registered * Lock usesContext api * Use Symbol instead of Math.random * Patterns Browse Screen: Fix back button when switching between categories (#52964) * Patterns: Allow orphaned template parts to appear in general category (#52961) * Spacing presets: fix bug with select control adding undefined preset values (#53005) * Site Editor: Fix canvas mode sync with URL (#52996) * Check if spacing tool is defined before displaying controls. (#53008) * Check if spacing tool is defined before displaying controls. * Don't show sides if spacing type false * Improve consistency of the Post editor and Site editor Document actions (#52246) * Remove redundant shortcut button. * Fix focus and hover style and improve consistency. * Rename post document-title and improve CSS consistency. * Site Editor: Fix the typo in the title label map (#53071) * Fix patterns search crash: check for existence of defaultView before attempting to get styles (#52956) * backport paging bug fixes (#53091) --------- Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Hiroshi Urabe <mail@torounit.com> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: Pedro Mendonça <ped.gaspar@gmail.com> Co-authored-by: Ella <4710635+ellatrix@users.noreply.github.com> Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: tellthemachines <tellthemachines@users.noreply.github.com> Co-authored-by: Andrea Fercia <a.fercia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to address part of #51460 and #51729
What?
The 'document title' / 'document actions' in the top bar are inconsistent between the Post editor and the Site editor, especially in 'editing template' mode.
Why?
How?
DocumentTitlecomponent toDocumentActionsfor consistency. Also, this component is not just the 'title'. It does more than that so the nameDocumentActionsseems more appropriate.About the CSS changes
Worth noting that on trunk the DocumentTitle / DocumentActions already have some layout issues, especially on small screens.
On desktop, long text overflow behaves differently. Screenshot of Post editor vs. Site editor:
The text overflow should work way better with this PR.
This PR does not aim to fix the layout breakage on small screens, especially in the Post editor. This should be addressed separately. Screenshot from trunk:
With long text:
Post editor, shorter text on even smaller screen:
Testing Instructions
⌘Kis not a separate button any longer.The quick, brown fox jumps over a lazy dog. DJs flock by when MTV ax quiz progAs said above, on small screens the layout isn't great and breaks. It already happens on trunk and should be addressed separately. Not in the scope of this PR.
Testing Instructions for Keyboard
Screenshots or screencast