Github workflow: add a PHP backport changes action#52096
Conversation
|
This pull request changed or added PHP files in previous commits, but none have been detected in the latest commit. Thank you! ❤️ |
3f4d26f to
7960733
Compare
0fed88c to
01836ac
Compare
|
Flaky tests detected in f41cd81c206647fdfee0a6db6389501973e73c61. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5417943681
|
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for the PR! Couple of comments below but otherwise LGTM
| *.{php} | ||
| lib/** | ||
| phpunit/** | ||
| packages/block-library/src/** |
There was a problem hiding this comment.
We can remove the block-library folder as those files get auto-generated from the core package update.
| echo "Changed files:" | ||
| formatted_change_list="" | ||
| for file in ${{ steps.changed-files-php.outputs.all_changed_files }}; do | ||
| echo "$file was changed" |
There was a problem hiding this comment.
Do we need this if we're already outputting all the changed files in the formatted list?
There was a problem hiding this comment.
I left it there in case we need to debug the script's steps by eyeballing the CI logs.
apeatling
left a comment
There was a problem hiding this comment.
I didn't test, but I say this is a good and reasonable change so let's do it. :)
Remove block library glob
* trunk: (36 commits) Use `_get_block_template_file` function and set $area variable. (#52708) Change Delete page menu item to Move to trash. (#52641) Search block: Enqueue view script through block.json (#52552) Patterns: fix bug with Create Patterns menu not showing in site editor page editing (#52671) Github workflow: add a PHP backport changes action (#52096) Add layout API documentation. (#52673) Show uncategorized patterns on the Editor > Patterns page (#52633) Patterns: Remove `reusable` text from menu once rename hint has been dismissed (#52664) Update locked pattern tooltips (#52497) Rich Text/Footnotes: fix getRichTextValues for useInnerBlocksProps.save (#52682) Use posts instead of template parts for navigation color tests (#52654) Site Editor: Don't allow creating template part on the Patterns page for non-block themes (#52656) Site Editor: Fix incorrect 'useSelect' usage (#52683) Update issue gardening automation with new label (#52173) i18n: Make the tab labels of `ColorGradientSettingsDropdown` component translatable (#52669) Post Content link color should not be applied to placeholder component links (#52367) [Mobile] Update toolbar icons and colors (#52336) Avoid copying global style presets via the styles compatibility hook (#52640) Show warning on removal of Post Template block in the site editor. (#52666) Backport tools: sort PRs to be cherry picked by merged/closed date (#52667) ...
What?
This is just a proposal...
Adds a Github action that:
/lib,/phpunitorblock-libraryNice to haves as a follow up (will probably require a custom Gutenberg action as the marketplace is a desert)
Why?
WordPress releases are hectic and would be made easier if plugin changes that are destined for Core are reviewed and tested against Core earlier.
How?
Adding a new github action YAML file.
Testing Instructions
/phpunit,/liborpackages/block-library/srcfolders to this branch (just edit comments if you like) and see if the message is appears.