Blocks: remove gutenberg refs in PHP files#51978
Merged
Conversation
…ible to avoid conflicts with Core.
ramonjd
commented
Jun 27, 2023
| $fallback_blocks = $registry->is_registered( 'core/page-list' ) ? $page_list_fallback : array(); | ||
|
|
||
| $navigation_post = Gutenberg_Navigation_Fallback::get_fallback(); | ||
| if ( class_exists( 'WP_Navigation_Fallback' ) ) { |
Member
Author
There was a problem hiding this comment.
Not sure if I this should be
if ( defined( 'IS_GUTENBERG_PLUGIN' ) && IS_GUTENBERG_PLUGIN ) {Same effect, just convention?
Contributor
There was a problem hiding this comment.
I'd go with the class_exists check, since the compat layer changes over time (and is thus not directly equivalent to the presence of the plugin).
tellthemachines
approved these changes
Jun 27, 2023
Contributor
tellthemachines
left a comment
There was a problem hiding this comment.
Code LGTM! Testing locally everything is working well.
spacedmonkey
approved these changes
Jun 27, 2023
ockham
pushed a commit
that referenced
this pull request
Jun 27, 2023
* Removes references to execution code referencing gutenberg where possible to avoid conflicts with Core. * Added deprecated notices * Removed `gutenberg_` for `IS_GUTENBERG_PLUGIN` only method
Contributor
|
Cherry-picked to the |
Contributor
|
@ramonjd @tellthemachines Should this also go into GB 16.1? |
Member
Author
It probably should have I think. I can't see it the changes in the branch or in the commit history. |
Member
Author
|
I think it's also missing 40aa280 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Removes references to execution code referencing gutenberg where possible to avoid conflicts with Core. * Added deprecated notices * Removed `gutenberg_` for `IS_GUTENBERG_PLUGIN` only method
This was referenced Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes references to execution code referencing gutenberg where possible.
Why?
To avoid conflicts with Core
How?
Keyboard!
Testing Instructions
Tests should pass.
Editor should load.