E2E tests: Try fixing 'networkidle' timeout errors#51826
Merged
Conversation
talldan
approved these changes
Jun 23, 2023
Contributor
talldan
left a comment
There was a problem hiding this comment.
Looks good to me, at least as a temporary measure until we have more idea about what's happening!
noisysocks
added a commit
that referenced
this pull request
Jun 28, 2023
This reverts commit d978b0b.
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Remove 'no-store' from the Cache-Control header when running E2E tests * Fix PHP lint errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of tests are timing out when they call
page.waitForLoadState( 'networkidle' ). @talldan rangit bisectand worked out that it's to do with a recent Core commit that adjusted theCache-Controlheaders set by WordPress. Removingno-storefrom the header seems to fix the issue.I'm pretty stumped as to why this happens. (A Chrome bug?) This PR simply uses the
nocache_headersfilter to removeno-storefromCache-Controlheader in our E2E test environment. Hopefully this fixes the tests and unblocks committers from doing work while we investigate what's actually going on here.Related Trac ticket: https://core.trac.wordpress.org/ticket/58592
Slack thread: https://wordpress.slack.com/archives/C02QB2JS7/p1687418950952019