Image block: Remove Lightbox markup if is set as disabled.#51692
Merged
cbravobernal merged 3 commits intotrunkfrom Jun 21, 2023
Merged
Image block: Remove Lightbox markup if is set as disabled.#51692cbravobernal merged 3 commits intotrunkfrom
cbravobernal merged 3 commits intotrunkfrom
Conversation
|
Flaky tests detected in 87357b0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5321942054
|
Contributor
There was a problem hiding this comment.
Two thoughts:
1.) While testing, I realized that when specifying default for the lightbox, the animation dropdown is visible when it shouldn't be. I can handle that on this branch or a separate PR, whichever you prefer, or feel free to tackle it if you have bandwidth
lightbox-dropdown-default.mp4
2.) We should probably add a test case for this.
Contributor
Author
|
I can add a test for the Lightbox markup issue. |
|
Size Change: +9.58 kB (+1%) Total Size: 1.42 MB
ℹ️ View Unchanged
|
artemiomorales
approved these changes
Jun 21, 2023
Contributor
artemiomorales
left a comment
There was a problem hiding this comment.
Ok looks good to me 👍
Thanks!
69 tasks
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…#51692) * Do not include lightbox markup if disabled * Add e2e test for markup issue * Rename test description
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Right now, even if you disable the Lightbox, the HTML code that makes this possible is still there. With this PR, if Lighbox is disabled, we don't add all that extra data.
Why?
We were adding no needed bytes and, also we caused a misbehavior, showing a magnifying glass that indicates a behavior that is not happening.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Before PR:
lightbox_before_pr.mov
After PR:
lightbox_after_pr.mov