Lodash: Remove more _.isEmpty() from block editor#51098
Merged
Conversation
|
Size Change: -5 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
tyxla
commented
May 30, 2023
Member
Author
There was a problem hiding this comment.
The colors argument is expected to be an array:
Member
Author
There was a problem hiding this comment.
Colors are expected to be an array in both tests and theme.json:
https://developer.wordpress.org/themes/advanced-topics/theme-json/#color-palette
Member
Author
There was a problem hiding this comment.
Colors are expected to be an array in both tests and theme.json:
https://developer.wordpress.org/themes/advanced-topics/theme-json/#color-palette
Member
Author
There was a problem hiding this comment.
Gradients are expected to be an array in both tests and theme.json:
https://developer.wordpress.org/themes/advanced-topics/theme-json/#color-palette
Member
Author
There was a problem hiding this comment.
Gradients are expected to be an array in both tests and theme.json:
https://developer.wordpress.org/themes/advanced-topics/theme-json/#color-palette
Member
Author
There was a problem hiding this comment.
Colors are expected to be an array in both tests and theme.json:
https://developer.wordpress.org/themes/advanced-topics/theme-json/#color-palette
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Comment on lines
984
to
985
Member
Author
There was a problem hiding this comment.
Selectors, if defined, will be an object:
https://developer.wordpress.org/block-editor/reference-guides/block-api/block-metadata/#selectors
Contributor
There was a problem hiding this comment.
Super nit: ? in blockType?.selector at the second check is not needed.
ntsekouras
approved these changes
Jun 1, 2023
Comment on lines
984
to
985
Contributor
There was a problem hiding this comment.
Super nit: ? in blockType?.selector at the second check is not needed.
dd0de89 to
262c8db
Compare
|
Flaky tests detected in 262c8db. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5143262280
|
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
* Lodash: Remove more _.isEmpty() from block editor * Remove unnecessary boolean check * Remove unnecessary optional chaining
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.isEmpty()from the block editor package.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're checking if the props are truthy, and if they are, we verify that it's not an empty object by using
Object.keys().length.Testing Instructions