Lodash: Remove _.isEmpty() from Fill props#51096
Merged
Conversation
|
Size Change: +23 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
tyxla
commented
May 30, 2023
| // So we re-create the Provider in this subtree. | ||
| const value = ! isEmpty( fillProps ) ? fillProps : null; | ||
| const value = | ||
| fillProps && Object.keys( fillProps ).length > 0 |
Member
Author
There was a problem hiding this comment.
fillProps should be an object since it's coming from component props:
| // Provider in this subtree. | ||
| const value = ! isEmpty( fillProps ) ? fillProps : null; | ||
| const value = | ||
| fillProps && Object.keys( fillProps ).length > 0 ? fillProps : null; |
Member
Author
There was a problem hiding this comment.
fillProps should be an object since it's coming from component props:
Mamaduka
approved these changes
Jun 1, 2023
Member
Mamaduka
left a comment
There was a problem hiding this comment.
The changes look good in my tests. Thank you, Marin!
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR removes Lodash's
_.isEmpty()from the usages that checkFillprops.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're checking if the props are truthy, and if they are, we verify that it's not an empty object by using
Object.keys().length.Testing Instructions