This PR has also allowed me to notice a potential refactor of settings drawer which I will do in a follow up.

Need to also fix the tests here.

Size Change: -1.1 kB (0%)

Total Size: 1.39 MB

_{compressed-size-action}

Flaky tests detected in 5369255ee6bc4d099738bbe894ebdb1369060105.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5119141123
📝 Reported issues:

• [Flaky Test] should not allow blocks to be inserted in inner blocks #44341 in specs/editor/plugins/cpt-locking.test.js

We are looking to migrate the Puppeteer tests to Playwright for Links. Once done we can rebase this (and other PRs) which will allow us to move forward more quickly.

@MaggieCabrera Once your test refactor PRs are merged I think it would be good to rebase here and try and get this in as soon as possible.

Currently failing on

const waitForURLFieldAutoFocus = async () => {
    > 20 | 		await page.waitForFunction(
         | 		           ^
      21 | 			() => !! document.activeElement.closest( '.block-editor-url-input' )
      22 | 		);
      23 | 	};

I made a fix for the tests because when we introduce the new input, the modal puts the focus on the text input when opened instead of the URL. I wonder if that's the behavior we want. In any case, the fixes for the e2e are merely a bandaid since these tests are incredibly dependent on the UI, and tabbing to get to where you want. I'll be working on migrating these all to playwright and rewriting them so they are more UI agnostic unless the purpose of the test is to focus on keyboard navigation.

@draganescu looking at the comments on the code that handles focus here I'm not so sure if we want the URL to be focused here (it was the text input before we removed it). In any case, maybe that can be handled in a follow-up?

The tests pass now, so this can be merged, I'm not sure if the focus issue is worth blocking this one. Happy to hear anyone else's thoughts.

The tests pass now, so this can be merged, I'm not sure if the focus issue is worth blocking this one.

Yea I think it's fine to merge. The edit view is getting revisited as a whole.