Merged
Conversation
Member
Author
|
I'm leaving fixes for the more tag out of this PR. It needs images and this doesn't seems like a trivial fix. |
Member
Member
Author
|
|
Member
|
It adds the |
gziolo
approved these changes
Feb 8, 2018
Member
gziolo
left a comment
There was a problem hiding this comment.
Let's make sure there is a follow-up PR to make the More tag visible inside the classic editor.
Member
|
Related: #4762 |
mtias
reviewed
Feb 9, 2018
| function gutenberg_wordpress_version_notice() { | ||
| echo '<div class="error"><p>'; | ||
| echo __( 'Gutenberg requires WordPress 4.8 or later to function properly. Please upgrade WordPress before activating Gutenberg.', 'gutenberg' ); | ||
| echo __( 'Gutenberg requires WordPress 4.9 or later to function properly. Please upgrade WordPress before activating Gutenberg.', 'gutenberg' ); |
Member
There was a problem hiding this comment.
so we want to bump the required version in the readme?
Member
There was a problem hiding this comment.
#4762 was closed instead of merged, but since this has been merged, it can be revisited.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This branch removes code adjusted core code for the TinyMCE inline mode to function properly in the classic block. It was fixed as part of WordPress 4.9, so this code is no longer needed.
WordPress/wordpress-develop@9b5781f#diff-ae1914402704971fe55f9d47f55d4bee
When testing this, I saw that the more tag does not display, but it doesn't seem like this ever worked properly.
How Has This Been Tested?
Insert a more tag in the classic block. There should be no errors.
Checklist: