Skip to content

Remove unused code after WP 4.9#4950

Merged
ellatrix merged 1 commit intomasterfrom
remove/classic-unneeded-code
Feb 8, 2018
Merged

Remove unused code after WP 4.9#4950
ellatrix merged 1 commit intomasterfrom
remove/classic-unneeded-code

Conversation

@ellatrix
Copy link
Copy Markdown
Member

@ellatrix ellatrix commented Feb 8, 2018

Description

This branch removes code adjusted core code for the TinyMCE inline mode to function properly in the classic block. It was fixed as part of WordPress 4.9, so this code is no longer needed.

WordPress/wordpress-develop@9b5781f#diff-ae1914402704971fe55f9d47f55d4bee

When testing this, I saw that the more tag does not display, but it doesn't seem like this ever worked properly.

How Has This Been Tested?

Insert a more tag in the classic block. There should be no errors.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

@ellatrix
Copy link
Copy Markdown
Member Author

ellatrix commented Feb 8, 2018

I'm leaving fixes for the more tag out of this PR. It needs images and this doesn't seems like a trivial fix.

@ellatrix ellatrix requested a review from a team February 8, 2018 10:27
@gziolo
Copy link
Copy Markdown
Member

gziolo commented Feb 8, 2018

screen shot 2018-02-08 at 13 57 39
Do we need to explicitly expose the version 4.9 to the plugins repository?

@ellatrix
Copy link
Copy Markdown
Member Author

ellatrix commented Feb 8, 2018

readme.txt is not tracked in this repository, so there's little I can do. Maybe it should be? Cc @matias.

@gziolo
Copy link
Copy Markdown
Member

gziolo commented Feb 8, 2018

It adds the More tag inside the classic editor, but it is visilibe only inside the source code. However it works as expected when I save post.

Copy link
Copy Markdown
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure there is a follow-up PR to make the More tag visible inside the classic editor.

@aduth
Copy link
Copy Markdown
Member

aduth commented Feb 8, 2018

Related: #4762

@ellatrix ellatrix merged commit d6a8a91 into master Feb 8, 2018
@ellatrix ellatrix deleted the remove/classic-unneeded-code branch February 8, 2018 16:44
function gutenberg_wordpress_version_notice() {
echo '<div class="error"><p>';
echo __( 'Gutenberg requires WordPress 4.8 or later to function properly. Please upgrade WordPress before activating Gutenberg.', 'gutenberg' );
echo __( 'Gutenberg requires WordPress 4.9 or later to function properly. Please upgrade WordPress before activating Gutenberg.', 'gutenberg' );
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we want to bump the required version in the readme?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, also for #4762 it seems.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4762 was closed instead of merged, but since this has been merged, it can be revisited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants