Skip to content

Compat: Remove unnecessary api-request shim#4762

Closed
aduth wants to merge 1 commit intomasterfrom
remove/api-request-shim
Closed

Compat: Remove unnecessary api-request shim#4762
aduth wants to merge 1 commit intomasterfrom
remove/api-request-shim

Conversation

@aduth
Copy link
Copy Markdown
Member

@aduth aduth commented Jan 30, 2018

This pull request seeks to remove the api-request JavaScript shim which had existed while WordPress 4.9 was in pre-release, in order to support the 4.8 stable release at the time. Since WordPress 4.9.x is now stable, this shim can now be removed. This effectively increases the minimum WordPress version supported by the Gutenberg plugin to 4.9.0.

Testing instructions:

Verify that the editor loads as expected, particularly that the api-request file is loaded correctly from the WordPress installation.

@aduth aduth added Framework Issues related to broader framework topics, especially as it relates to javascript REST API Interaction Related to REST API labels Jan 30, 2018
@noisysocks
Copy link
Copy Markdown
Member

This effectively increases the minimum WordPress version supported by the Gutenberg plugin to 4.9.0.

Do we document this somewhere?

@aduth
Copy link
Copy Markdown
Member Author

aduth commented Feb 2, 2018

Do we document this somewhere?

Hmm, not to my knowledge.

I suppose there's not too much harm in keeping this around, at least until part of a merge proposal (where it'd certainly be redundant).

Gonna go ahead and close for now.

@aduth aduth closed this Feb 2, 2018
@aduth aduth deleted the remove/api-request-shim branch February 2, 2018 14:25
@aduth
Copy link
Copy Markdown
Member Author

aduth commented Feb 8, 2018

Not documented, but I did find this:

gutenberg/gutenberg.php

Lines 123 to 126 in d9a6655

if ( version_compare( $version, '4.8', '<' ) ) {
add_action( 'admin_notices', 'gutenberg_wordpress_version_notice' );
return;
}

@aduth aduth mentioned this pull request Feb 8, 2018
3 tasks
@aduth aduth restored the remove/api-request-shim branch February 19, 2018 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Issues related to broader framework topics, especially as it relates to javascript REST API Interaction Related to REST API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants