Show close button in List View on mobile#49200
Merged
Merged
Conversation
|
Size Change: +11 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 655d9df. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4467473720
|
Mamaduka
approved these changes
Mar 20, 2023
Mamaduka
left a comment
Member
There was a problem hiding this comment.
Thank you, Nik!
I think this is a good "hotfix" for WP 6.2. Let's follow up with suggested TabsPanel improvements, plus responsive tweaks for this sidebar, like removing extra spaces and letting elements go full-width on smaller screens.
Screenshot
Member
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 66c1adc |
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 21, 2023
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. See #57471. Fixes #57929. git-svn-id: https://develop.svn.wordpress.org/trunk@55568 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 21, 2023
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. See #57471. Fixes #57929. Built from https://develop.svn.wordpress.org/trunk@55568 git-svn-id: http://core.svn.wordpress.org/trunk@55080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions Bot
pushed a commit
to platformsh/wordpress-performance
that referenced
this pull request
Mar 21, 2023
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. See #57471. Fixes #57929. Built from https://develop.svn.wordpress.org/trunk@55568 git-svn-id: https://core.svn.wordpress.org/trunk@55080 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Mar 21, 2023
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. Reviewed by SergeyBiryukov, audrasjb. Merges [55568] to the 6.2 branch. See #57471. Fixes #57929. git-svn-id: https://develop.svn.wordpress.org/branches/6.2@55570 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Mar 21, 2023
Updates the `@wordpress` packages to include the fixes for these regressions introduced in the 6.2 cycle: * [Regression] Navigation Block: Category/Custom taxonomy links are not searchable in the Link inserter [WordPress/gutenberg#49126 Gutenberg PR 49126]. See #57929 ✅ * [Regression] Post Editor: List View has no close button on mobile viewports [WordPress/gutenberg#49200 Gutenberg PR 49200] ✅ References: * [WordPress/gutenberg@811da1a Packages x.3.11 publish commit]. Follow-up to [55548]. Props andraganescu, costdev, get_dave, hellofromTonya, mamaduka, ntsekouras, scruffian, talldanwp, thomask. Reviewed by SergeyBiryukov, audrasjb. Merges [55568] to the 6.2 branch. See #57471. Fixes #57929. Built from https://develop.svn.wordpress.org/branches/6.2@55570 git-svn-id: http://core.svn.wordpress.org/branches/6.2@55082 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #48982
This is hot fix for showing the
closebutton in List View when we inadvertently end up with the full screen list in mobile. This is not intended right now as he hide theList Viewtoggle in smaller viewports, but we can end up with it by having the respectivepreferenceset(always open list view) or by having it open and resize the viewport.I've made the minimum changes here in order to add it in
6.2. We probably need to evaluate this in more depth about the similar Tab Panel implementations in the code base, and also probably hiding it in mobile or updating how it works there in conjunction with the clarification of the preference that has not the effect expected in mobile.