Override React dependency of React Native#48990
Conversation
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 2574123. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4383805371
|
1ac95d8 to
e471f3d
Compare
8e3d900 to
3bcbf37
Compare
|
Looks like this was meant as a follow-up to the Node upgrade right? We should be able to retry this. |
This PR is no longer needed as we recently upgraded React Native to a version that uses React 18.2.0. Hence, we can close it. I've tried disabling Click here to display warnings |
|
Awesome thank you @fluiddot we'll take it from there. |
|
Hey @fluiddot I've been doing some cleanup to the dependencies we have based on the list of deprecated packages "npm install" shows. See #53520 #53515 #53478 I've managed to clean a good chunk of them, there's still a dozen left and most of them are due to some native dependencies like "metro" or "react-native-sass-transformer", just wanted to let you know in case it's something that you or your colleagues can help with at some point (there's obviously no urgency here) |
Hey @youknowriad 👋 ! Sure, I'm thinking to create a GitHub issue as a follow-up with the deprecated packages related to React Native. I assume the deprecated packages you're referring to are the following ones, is this accurate? Click here to display deprecated packages and their dependencies
|
|
Yep, great list. That's actually very helpful (to see the parent dependencies). I see there's a few I can help with too. |
|
I've created this GitHub issue #53569 for tracking the task of cleaning up the deprecated packages and including all the information above. |
What?
This PR adds an enhancement to #48950 in order to remove the NPM's
legacy-peer-depsconfiguration option.Why?
Usage of
legacy-peer-depsconfiguration option is not recommended by NPM:How?
0.69.4uses an older React version (18.0.0), however as explained in Dependency conflict when installing dependencies using npm 8 #46443 (comment), seems safe to override the React version for this dependency. This override could be removed once the React Native version is upgraded to0.71or above.legacy-peer-depsoption.package-lock.jsonfile.legacy-peer-depswill make NPM display the following warnings related to other dependency conflicts when installing the depedencies:@mdx-js/react@1.6.22:NPM warning
ajv-keywords@3.4.1:NPM warning
react-element-to-jsx-string@14.3.4:NPM warning
react-element-to-jsx-string@14.3.4:NPM warning
react-inspector@5.1.1:NPM warning
webpack-filter-warnings-plugin@1.2.1:NPM warning
In the future, it would be great to solve them to remove the warnings.
Testing Instructions
Follow the same testing instructions outlined in #48950.
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A