Upgrade Lerna to the latest version#53515
Merged
youknowriad merged 1 commit intotrunkfrom Aug 10, 2023
Merged
Conversation
|
Size Change: 0 B Total Size: 1.5 MB ℹ️ View Unchanged
|
Member
|
It's a bit concerning that after upgrading Lerna and running I guess it is what it is 🤷🏻 |
gziolo
approved these changes
Aug 10, 2023
Member
gziolo
left a comment
There was a problem hiding this comment.
If CI jobs pass we should be good, and let's hope that the lock file becomes more stable moving on.
Contributor
Author
|
Let's also keep an eye on the next npm publish for any potential failures... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
While doing the node/npm migration, I've noticed a few messages when installing packages. Among them, the fact that we're using a few deprecated packages. I'm trying to clean these out a little bit.
I noticed that our Lerna's dependency was responsible for 3 or 4 of these warnings, so in this PR I'm trying to upgrade it to the latest version.
How?
Also, as recommended by Lerna's changelog. I've run
lerna repairwhich updated the lerna.json file.Testing Instructions
It's a bit hard to test all the commands because some of them are only run when publishing packages. but I tried
npm run publish:checkand it seems to work as intended and we're also using somelernain the build command which is run in CI.