WP_HTML_Tag_Processor: Support tag closer bookmarks#48692
Merged
Conversation
hellofromtonya
approved these changes
Mar 2, 2023
Contributor
hellofromtonya
left a comment
There was a problem hiding this comment.
Thank you @ockham for synchronizing this change from Core into Gutenberg for parity.
Confirm the changes match https://core.trac.wordpress.org/changeset/55407 ✅
This PR LGTM 👍
adamziel
approved these changes
Mar 2, 2023
Contributor
Author
ockham
added a commit
that referenced
this pull request
Mar 2, 2023
In the 6.2 compat layer, support bookmarks pointing to closing tags. This is for parity with Core in WP 6.2, see WordPress/wordpress-develop#4115 and [r55407](https://core.trac.wordpress.org/changeset/55407). Note that these changes have already been backported to GB's 6.**3** compat layer in #48378. However, since the change will be in WP 6.2, we also have to apply it to GB's 6.2 compat layer.
Contributor
Author
|
Cherry-picked to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the 6.2 compat layer, support bookmarks pointing to closing tags.
Why?
For parity with Core in WP 6.2, authored by @adamziel in WordPress/wordpress-develop#4115 and committed by @hellofromtonya in r55407.
Note that these changes have already been backported to GB's 6.3 compat layer by @dmsnell in #48378. However, since the change will be in WP 6.2, we also have to apply it to GB's 6.2 compat layer.