Post Editor: Update postContentBlock check to see if the block is valid#48386
Merged
andrewserong merged 1 commit intoFeb 23, 2023
Merged
Conversation
|
Size Change: +10 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
tellthemachines
approved these changes
Feb 23, 2023
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing this! Tested with the steps from #48355 and this fix works for that issue. I think we should get this into 6.2 ✅
Contributor
Author
|
@Mamaduka @ntsekouras just for visibility, it'd be great to get this fix into the next 6.2 beta release if we can, as it resolves one of the issues folks testing the release have flagged about wide/full alignments not showing up in the post editor. |
Member
|
This is quite a regression, definitely a high priority bug for 6.2, and let's make sure to ship a quick plugin release to address it as well. |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 27, 2023
Contributor
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: d44b065 |
DaisyOlsen
pushed a commit
that referenced
this pull request
Feb 27, 2023
Contributor
|
I have cherry-picked this PR to the release/15.2 branch to get it into the 15.2.2 minor release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #48355
In the post editor's visual editor component, the post content block for the current template is fetched. There is a conditional that checks whether or not the post content block was found, however the fallback state of
postContentBlockis an empty object, which means it's always truthy. If we update this topostContentBlock?.isValidwhich only exists when the value is a real parsed block, then this should fix up the failure state.Why?
When logged in as a non-admin user that cannot edit templates (e.g. an Author role) then the edited template cannot be retrieved. In this state, we should use the fallback layout which allows for constrained layout and full/wide controls, however this wasn't happening.
How?
isValidso that an empty object doesn't accidentally return trueTesting Instructions
Screenshots or screencast