Style Book: Allow button text labels for style book icon#48088
Merged
andrewserong merged 4 commits intoFeb 16, 2023
Conversation
|
Size Change: +711 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 39d84d9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4188586411
|
|
Thanks for the PR @andrewserong! The code looks good to me on first glance. It does seems that the Playwright e2e test that has been changed is failing now, so that might require a bit more testing. |
kevin940726
requested changes
Feb 15, 2023
joedolson
approved these changes
Feb 15, 2023
joedolson
left a comment
Contributor
There was a problem hiding this comment.
Looks good from the accessibility side. Thanks!
apeatling
approved these changes
Feb 15, 2023
apeatling
left a comment
Contributor
There was a problem hiding this comment.
✅ Tested and the text label now displays correctly.
LGTM with Kai's suggested change. 👍
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Contributor
Author
|
Thanks @kevin940726, that fixed up the failing e2e test! Do you mind giving this another look when you get a chance? I think we need your ✅ before it'll unlock merging 🙂 |
Contributor
Author
|
Thanks @kevin940726! 🙂 |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 20, 2023
* Global styles sidebar: Allow text labels on buttons * Simplify labels * Update e2e tests * Fix failing test Co-authored-by: Kai Hao <kevin830726@gmail.com> --------- Co-authored-by: Kai Hao <kevin830726@gmail.com>
Contributor
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: e5ea64e |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes #48051
As raised in the linked issue, when using the
Show button text labelseditor setting, the icon for the Style Book button is still displayed as an icon, rather than its text label. This PR allows that setting to switch the Style Book icon over to using its text label, and also tweaks the text labels in that row.Why?
The style book icon isn't self-explanatory, and for users who use the
Show button text labelssetting, the expectation is that a text label would be used instead of an icon.How?
.show-icon-labelsclassname that gets output to the site editor when theShow button text labelssetting is in use, add CSS rules that hide thesvgelement and display the aria-label text for the button instead.Open Style BookandClose Style BooktoStyle Bookbased on the feedback in Stylebook: icon doesn't respect text-only buttons option #48051 (comment).More styles actionstoStyles actionsfor consistency and to better fit the text labels on a single row.Stylestext does not shrink smaller than its content (add amin-width: min-contentrule).Note: the close button has not been included in the button label text in this PR as there is currently limited space in this row to fit each of the elements. This could be explored separately in a follow-up if it's desired to include that one, too.
Happy for any feedback on the labelling, though!
Testing Instructions
Style BookNote: the capitalisation here is a little off — that's because
Style Bookappears to be a proper noun, whereasStyles actionsis sentence case as it is not a proper noun. Happy for any feedback or suggestions there.Screenshots or screencast