[Layout]: Fix align controls for hybrid themes#47961
Merged
Merged
Conversation
|
Size Change: +84 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Feb 10, 2023
Mamaduka
left a comment
Member
There was a problem hiding this comment.
- I can confirm this fixes regression for hybrid themes. Tested Group, Cover, and Image blocks ✅
- I don't see any regressions for block themes ✅
- The code is straightforward and looks good to me 👍
|
Flaky tests detected in 609564e. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4143098635
|
tellthemachines
approved these changes
Feb 12, 2023
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing this!
I think the isBlockBasedTheme check makes sense as long as the definition of hybrid theme is a theme with PHP templates and a theme.json file, but we should be aware that this will fail if the theme includes an index.html file.
It should be ok for this change to go in though, considering that __unstableIsBlockBasedTheme is already in core and this will fix the issue for many (perhaps most?) hybrid themes.
andrewserong
approved these changes
Feb 12, 2023
andrewserong
left a comment
Contributor
There was a problem hiding this comment.
+1 thanks for the straightforward fix!
✅ Confirmed issue on trunk that a classic theme with a theme.json file and opted in to add_theme_support( 'align-wide' ); results in no wide / full width controls being available
✅ With this PR applied, the wide / full width controls are restored
✅ In a block-based theme, children of flow layout still correctly do not show wide/full alignments as those children are already full width to the container
LGTM! ✨
Contributor
Author
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 1ef68f9 |
This was referenced Feb 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fixes: #47857
From the issue:
Step-by-step reproduction instructions
Tested with WordPress 6.2 beta1 nightly without Gutenberg plugin.