Add an aria label to the site save dialog#47898
Merged
Merged
Conversation
|
Size Change: +21 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 469ab7a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4131439375
|
alexstine
reviewed
Feb 9, 2023
alexstine
left a comment
Contributor
There was a problem hiding this comment.
@glendaviesnz Thanks for the PR.
Not a huge fan that dialogs could not have headings. This is really an anti-pattern in my opinion.
With that aside, one small edit so screen readers read this properly. I know, your version is also correct English but screen readers are picky.
Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com>
Contributor
Author
Thanks for the input @alexstine. I have noted on #47885 that with an immediate fix for 6.2 merged we could now repurpose that issue to focus on the question of titles in dialogs more generally. |
Contributor
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: d4c6581 |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 13, 2023
* Add an aria label to the site save dialog * Update wording Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com> --------- Co-authored-by: Kai Hao <kevin830726@gmail.com> Co-authored-by: Alex Stine <alex.stine@yourtechadvisors.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds an
aria-labelto the site save dialogWhy?
It doesn't currently have one, and also has no heading, so should have the aria-label as a minimum, while options for retaining heading but visually hidden when
__experimentalHideHeaderis set are explored.Part of fix for #47885
How?
Adds the
contentLabelprop which is converted by the component into an aria-labelTesting Instructions
Make some changes in the site editor and return to browser mode without saving them
Click on save button at bottom of left panel
Check that the save dialog has an aria label
Screenshots or screencast
Before:
After: