ToolsPanel: Ensure display of optional items when panel id is null#47864
Merged
aaronrobertshaw merged 3 commits intotrunkfrom Feb 9, 2023
Merged
Conversation
This ensures the panel will display an optional control when its value has been updated externally to the control within the ToolsPanelItem and the panel id is null e.g. when pasting styles on multiple block selections.
|
Size Change: +11 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 7272c30. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4121797714
|
glendaviesnz
approved these changes
Feb 8, 2023
Contributor
glendaviesnz
left a comment
There was a problem hiding this comment.
This tested well for me:
✅ Tests passed
✅ Optional tools panel items displayed when styles pasted to single and multiple blocks
✅ Default items still work as expected with menu items being updated when values customised, etc.
Contributor
|
Do we need this to be backported to 6.2 ? Feel free to remove the label, in case we don't :) |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 9, 2023
Contributor
|
Cherry-picked this PR to the wp/6.2 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related:
What?
Ensures optional tools panel items are toggled on for display, even when the panel Id is
null, e.g. when pasting styles on a multi-block selection.Why?
When you paste styles, you expect to be able to see the design tools containing the styles you are pasting.
How?
Testing Instructions
npm run test:unit:watch packages/components/src/tools-panelScreenshots or screencast
Screen.Recording.2023-02-08.at.5.23.29.pm.mp4
Screen.Recording.2023-02-08.at.5.05.32.pm.mp4