Copy failing WP_HTML_Tag_Processor_Bookmark_Test tests from Core#47720
Copy failing WP_HTML_Tag_Processor_Bookmark_Test tests from Core#47720noisysocks merged 2 commits intotrunkfrom
Conversation
There was a problem hiding this comment.
This change LGTM since it'll be testing against the core version... however, should we also update this line: https://github.com/WordPress/gutenberg/blob/trunk/lib/experimental/html/class-wp-html-tag-processor.php#L602 to use the _doing_it_wrong line from core, for consistency? (Without this change, PHP tests might fail locally for folks if they're testing against WP 6.1)
_doing_it_wrong(
__METHOD__,
__( 'Too many bookmarks: cannot create any more.' ),
'6.2.0'
);
return false;
In a follow-up it'd be good to switch the GB tests over to a Gutenberg prefixed or suffixed version of the tag class, if we can.
There was a problem hiding this comment.
Thanks for updating! Just confirmed that the PHP tests are passing locally, and smoke tested the tag processor is outputting classnames correctly on the site frontend for the position and layout supports.
Assuming the Github Actions still pass, this LGTM, thanks for the quick PR! ✨
|
Ah yeah good point. Done. I'll leave it up to someone else (@dmsnell, probably) to work out what to do with the Footnotes
|
|
Flaky tests detected in ee45b79. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4080944147
|
|
Thanks all. The current plan is simply to move the the Core version of the tag processor into |
PHP unit tests are failing on
trunk:https://github.com/WordPress/gutenberg/actions/runs/4080664124/jobs/7033415868
I noticed the two failing tag processor tests were different to what's in Core. Assumedly something changed in the implementation during the process of committing. To fix, I simply replaced the implementation of these failing tests with the one that's in Core.