Skip to content

Shadow: add shadow presets support via theme.json#46813

Merged
oandregal merged 1 commit intotrunkfrom
shadow-presets-themejson
Dec 29, 2022
Merged

Shadow: add shadow presets support via theme.json#46813
oandregal merged 1 commit intotrunkfrom
shadow-presets-themejson

Conversation

@madhusudhand
Copy link
Copy Markdown
Member

@madhusudhand madhusudhand commented Dec 29, 2022 •
edited by oandregal
Loading

What?

This adds support for default and theme shadow presets via theme.json

It ads following default presets to Gutenberg bundled theme.json

  • Natural
  • Sharp

Testing Instructions

  1. This change should create two default preset variables --wp--preset--shadow--natural and --wp--preset--shadow--sharp in global style sheet.
  2. Add the following styles in the current active theme.
"settings": {
		"shadow": {
			"palette": [
				{
					"name": "Natural",
					"slug": "theme-natural",
					"shadow": "5px 5px 0px -2px #FFFFFF, 5px 5px #000000"
				},
				{
					"name": "Crisp",
					"slug": "theme-crisp",
					"shadow": "5px 5px #000000"
				},
				{
					"name": "Sharp",
					"slug": "theme-sharp",
					"shadow": "5px 5px 0 0 #999999"
				},
				{
					"name": "Soft",
					"slug": "theme-soft",
					"shadow": "5px 5px 10px 0 #999999"
				}
			]
		}
}
  1. Verify that it creates the respective preset variables in global style sheet.
  2. Apply shadow to any block such as button in the current active theme.
{
    "styles": {
         "elements": {
              "button": {
                  "shadow": "var(--wp--preset--shadow--natural)"
              }
         }
    }
}
  1. Verify the button shadow.

This is a PR to add support via theme.json.
Verify end to end feature including UI in global styles from here #46502

Related issues

Partial Fix for #44651

@madhusudhand madhusudhand self-assigned this Dec 29, 2022
@madhusudhand madhusudhand mentioned this pull request Dec 29, 2022
Merged
@madhusudhand
add shadow presets in global styles
203d956 
update shadow values

fetch the updated core theme.json file

update class name of json ressolver
@madhusudhand madhusudhand force-pushed the shadow-presets-themejson branch from 33b5693 to 203d956 Compare December 29, 2022 08:55
oandregal
oandregal approved these changes Dec 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@oandregal oandregal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for splitting the work in smaller steps!

I've tested a variety of scenarios: defining the presets in the theme.json of the theme instead of using the theme.json bundled by Gutenberg, using the shadow in a block. I've also tested that style variations work the same as the main theme.json of the theme (needed to merge #46810 into this one). This is ready to ship.

@oandregal oandregal merged commit aa5bca2 into trunk Dec 29, 2022
@oandregal oandregal deleted the shadow-presets-themejson branch December 29, 2022 11:23
@github-actions github-actions bot added this to the Gutenberg 14.9 milestone Dec 29, 2022
This was referenced Jan 5, 2023
Closed
Closed
@courtneyr-dev courtneyr-dev mentioned this pull request Jan 13, 2023
Closed
38 tasks
@bgardner bgardner mentioned this pull request Jan 18, 2023
Closed
This was referenced Jan 25, 2023
Closed
Closed
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Feb 1, 2023
@hellofromtonya
Themes: Add shadow presets support for theme.json.
7374cde 
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by 

* Adding it to presets metadata and valid settings.
* Defining the default shadow presets in Core's `theme.json`.

Includes PHPUnit tests. 

References:
* [WordPress/gutenberg#46813 Gutenberg PR 46813]
* [WordPress/gutenberg#47272 Gutenberg PR 47272]

Follow-up to [54162], [52049], [50973].

Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya.
Fixes #57559.

git-svn-id: https://develop.svn.wordpress.org/trunk@55176 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Feb 1, 2023
@hellofromtonya
Themes: Add shadow presets support for theme.json.
263ef55 
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by 

* Adding it to presets metadata and valid settings.
* Defining the default shadow presets in Core's `theme.json`.

Includes PHPUnit tests. 

References:
* [WordPress/gutenberg#46813 Gutenberg PR 46813]
* [WordPress/gutenberg#47272 Gutenberg PR 47272]

Follow-up to [54162], [52049], [50973].

Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya.
Fixes #57559.
Built from https://develop.svn.wordpress.org/trunk@55176


git-svn-id: http://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Feb 1, 2023
@hellofromtonya
Themes: Add shadow presets support for theme.json.
3315303 
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by 

* Adding it to presets metadata and valid settings.
* Defining the default shadow presets in Core's `theme.json`.

Includes PHPUnit tests. 

References:
* [WordPress/gutenberg#46813 Gutenberg PR 46813]
* [WordPress/gutenberg#47272 Gutenberg PR 47272]

Follow-up to [54162], [52049], [50973].

Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya.
Fixes #57559.
Built from https://develop.svn.wordpress.org/trunk@55176


git-svn-id: https://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@Olein-jp Olein-jp mentioned this pull request Feb 11, 2023
Closed
VenusPR pushed a commit to VenusPR/Wordpress_Richard that referenced this pull request Mar 9, 2023
@devsyncer
Themes: Add shadow presets support for theme.json.
0302b5b 
Adds shadow presets support for `theme.json` within the `WP_Theme_JSON` by 

* Adding it to presets metadata and valid settings.
* Defining the default shadow presets in Core's `theme.json`.

Includes PHPUnit tests. 

References:
* [WordPress/gutenberg#46813 Gutenberg PR 46813]
* [WordPress/gutenberg#47272 Gutenberg PR 47272]

Follow-up to [54162], [52049], [50973].

Props madhudollu, mamaduka, oandregal, scruffian, hellofromTonya.
Fixes #57559.
Built from https://develop.svn.wordpress.org/trunk@55176


git-svn-id: http://core.svn.wordpress.org/trunk@54709 1a063a9b-81f0-0310-95a4-ce76da25c4cd
@t-hamano t-hamano mentioned this pull request Mar 20, 2023
Merged
@madhusudhand madhusudhand mentioned this pull request Dec 15, 2023
Closed
7 tasks
@bgardner bgardner mentioned this pull request Jan 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oandregal oandregal oandregal approved these changes

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

@ajlende ajlende Awaiting requested review from ajlende

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@madhusudhand madhusudhand

Labels

None yet

Projects

None yet

Milestone

Gutenberg 14.9

Development

Successfully merging this pull request may close these issues.

2 participants

@madhusudhand @oandregal