Reverts the custom CSS to an experiment while we resolve the handling of unfiltered html capabilities#46663
Merged
noisysocks merged 2 commits intotrunkfrom Dec 20, 2022
Merged
Conversation
… of unfiltered html capabilities
|
Size Change: +35 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
Closed
ramonjd
approved these changes
Dec 19, 2022
Member
ramonjd
left a comment
There was a problem hiding this comment.
Working as described. When the experiment is enabled, I can use the CSS field as expected.
With the experiment off:
With the experiment on:
Just left an optional note to change the copy to make it consistent with other labels, and to add a link to docs.
Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
Contributor
Author
|
@ryanwelcher needs backporting to 14.8 - thanks! |
This was referenced Dec 20, 2022
Contributor
|
I just cherry-picked this PR to the release/14.8 branch to get it included in the next release: e211c87 |
ryanwelcher
pushed a commit
that referenced
this pull request
Dec 20, 2022
… of unfiltered html capabilities (#46663) * Reverts the custom CSS to an experiment while we resolve the handling of unfiltered html capabilities * Update copy Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com>
This was referenced Jan 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Makes custom CSS experimental
Why?
Currently if the user does not have unfiltered HTML capability the custom CSS is not saved and no indication is given to the user. At the moment a valid
canUserUseUnfilteredHTMLselector is not available in the site editor as the current selector is tied to the current post, so while this issue is resolved it will be better to have this option under an experimental flag.How?
Only display custom CSS input if
gutenberg-global-styles-custom-cssexperiment is toggled onTesting Instructions
Screenshots or screencast