[RNMobile] Temporarily skip failing copy/paste tests#46340
Merged
Conversation
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
derekblank
approved these changes
Dec 7, 2022
derekblank
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for adding this fix. 🚀
This was referenced Dec 7, 2022
Contributor
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
fluiddot
reviewed
Dec 14, 2022
Comment on lines
+15
to
+17
| // Tests associated with this const are temporarily off for both platforms due to failures. | ||
| // They should be enabled for Android-only when a fix is in place. | ||
| const onlyOnAndroid = it.skip; |
Contributor
There was a problem hiding this comment.
@SiobhyB @derekblank I feel it can be a bit misleading that we keep calling the constant onlyOnAndroid when we are skipping the test on both platforms 😅. Maybe we could directly use it.skip on those tests and add this comment as a reference that we'll re-enable them in the future when we provide a fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
This PR manually skips some E2E tests that are currently failing.
Why?
The following E2E tests have been failing since #45235 was merged into
trunk:Despite the fact that these tests are failing, copy/paste appears to still be working as expected. To verify this, a test build can be found at wordpress-mobile/WordPress-Android#17612.
While we work on a more permanent fix for the E2E tests, this PR will temporarily skip them in the interest of reducing the noise that's coming from these incorrect failures.
How?
.skipis called in order to achieve what we want. The plan is for this to be a temporary solution while we work towards a more permanent fix.Testing Instructions
With this branch checked out, verify that the tests pass via the following commands:
npm run native test:e2e:android:local gutenberg-editor-pastenpm run native test:e2e:android:local gutenberg-editor-drag-and-dropIt would also be useful to verify that these failures are in fact false by manually testing the installable build available at wordpress-mobile/WordPress-Android#17612.